Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAN-1808] upgrade python to 3.12 and switch to poetry #6

Merged
merged 3 commits into from
May 7, 2024
Merged

[PAN-1808] upgrade python to 3.12 and switch to poetry #6

merged 3 commits into from
May 7, 2024

Conversation

danut13
Copy link
Member

@danut13 danut13 commented May 6, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  1. Support higher versions of Python3.10.
  2. Replace pip with poetry for dependency management.
  3. Replace setuptools with poetry for packaging.
  4. Use CI shared pipeline together with SonarCloud.

QA Instructions

The upstream projects (service node, validatornode etc.) should work as before.

@danut13 danut13 added the enhancement New feature or request label May 6, 2024
@danut13 danut13 self-assigned this May 6, 2024
@danut13 danut13 requested review from a team and markuslevonyak as code owners May 6, 2024 15:47
@danut13 danut13 changed the title feat: upgrade python to 3.12 and switch to poetry [PAN-1809] upgrade python to 3.12 and switch to poetry May 6, 2024
@danut13 danut13 requested review from a team, chandraprakash and jpantos and removed request for a team and jpantos May 6, 2024 15:49
juanmanuel-tirado
juanmanuel-tirado previously approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@juanmanuel-tirado juanmanuel-tirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@danut13 danut13 enabled auto-merge (squash) May 7, 2024 09:27
@danut13 danut13 merged commit e3ffd62 into main May 7, 2024
10 checks passed
@danut13 danut13 deleted the PAN-1808-upgrade-python-and-switch-to-poetry branch May 7, 2024 10:02
@danut13 danut13 changed the title [PAN-1809] upgrade python to 3.12 and switch to poetry [PAN-1808] upgrade python to 3.12 and switch to poetry May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuslevonyak markuslevonyak markuslevonyak approved these changes

@juanmanuel-tirado juanmanuel-tirado juanmanuel-tirado approved these changes

@chandraprakash chandraprakash chandraprakash approved these changes

Assignees

@danut13 danut13

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danut13 @chandraprakash @juanmanuel-tirado @markuslevonyak